Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

target/riscv: Remove duplicate read PC message #915

Merged
merged 1 commit into from
Oct 5, 2023
Merged

target/riscv: Remove duplicate read PC message #915

merged 1 commit into from
Oct 5, 2023

Conversation

timsifive
Copy link
Collaborator

Change-Id: Ie085758e3cf193f2671ea53fb82fd401d0c52d86

@timsifive
target/riscv: Remove duplicate read PC message
3acc277 
Change-Id: Ie085758e3cf193f2671ea53fb82fd401d0c52d86
Signed-off-by: Tim Newsome <tim@sifive.com>
@timsifive timsifive changed the title target/riscv: Don't print DPC if read fails target/riscv: Remove duplicate read PC message Sep 25, 2023
@timsifive timsifive mentioned this pull request Sep 25, 2023
Merged
@en-sc
Copy link
Collaborator

en-sc commented Sep 26, 2023

Is this neccesary? GDB_REGNO_PC != GDB_REGNO_DPC. I would like for it to be represented in -d3 log in some form. Maybe it would be sufficient to only remove the printing of the value, but leave the message?

@timsifive
Copy link
Collaborator Author

If we're printing the message, we should also print the value.

I don't really care. I just don't want to print the value when it might be uninitialized.

@timsifive timsifive merged commit 599e0a2 into riscv Oct 5, 2023
5 checks passed
@timsifive timsifive deleted the dpc_print branch October 5, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanMatCodasip JanMatCodasip JanMatCodasip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timsifive @en-sc @JanMatCodasip